-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG, ENH: Add resizing when time_viewer is present #7775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 tasks
larsoner
commented
Jun 3, 2020
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Member
Author
|
@GuillaumeFavelier can you add tests for size? I started to add some but the size was wrong for one run, things don't work with latest pyvista + pyvistaqt, etc. so it was not trivial |
Contributor
|
I'll take care of it |
* upstream/master: (23 commits) MAINT: Add mne.surface to docstring tests (mne-tools#7930) MRG: Add smoothing controller to TimeViewer for the notebook backend (mne-tools#7928) MRG: TimeViewer matplotlib figure color (mne-tools#7925) fix typos (mne-tools#7924) MRG, ENH: Add method to project onto max power ori (mne-tools#7883) WIP: Warn if untested NIRX device (mne-tools#7905) MRG, BUG: Fix bug with volume morph and subject_to!="fsaverage" (mne-tools#7896) MRG, MAINT: Clean up use of bool, float, int (mne-tools#7917) ENH: Better error message for incompatible Evoked objects (mne-tools#7910) try to fix nullcontext (mne-tools#7908) WIP: Fix Travis (mne-tools#7906) WIP: Prototype of notebook viz (screencast) (mne-tools#7758) MRG, FIX: Speed up I/O tests, mark some slow (mne-tools#7904) Proper attribution for Blender tutorial (mne-tools#7900) MAINT: Check usage [ci skip] (mne-tools#7902) Allow find_bad_channels_maxwell() to return scores (mne-tools#7845) Warn if NIRx directory structure has been modified from original format (mne-tools#7898) Pin pvyista to 0.24.3 (mne-tools#7899) MRG: Add support for reading and writing sufaces to .obj (mne-tools#7824) Fix _auto_topomap_coords docstring. (mne-tools#7895) ...
4 tasks
* upstream/master: MRG: Prepare migration to PyVista 0.25 (mne-tools#7791) MAINT: Simpler VTK [circle front] (mne-tools#7931) MRG, ENH: Add arbitrary connectivity for stats (mne-tools#7916)
agramfort
approved these changes
Jun 25, 2020
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Jun 25, 2020
* upstream/master: MRG, ENH: Add resizing when time_viewer is present (mne-tools#7775)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR this code snippet correctly sets the render area to the requested
size=(800, 600), and yet is resizeable afterward:MWE
@GuillaumeFavelier can you take over to actually incorporate this properly? For example this also needs to work when
time_viewer=False(it does not currently) -- you can probably use similar techniques. But I'll let you decide how to refactor to make it work for both cases.