-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG, DOC: note on using picard for same solution as other algos #8037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good - I think this is something that people are not very much aware of. We should advertise this on the EEGLAB mailing list 😄. |
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
however, digging into this, I also saw that picard is currently not tested for Python 3 --> mind-inria/picard#22 |
agramfort
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really happy to see other people saying the same thing :)
we'll catch up on testing and release / doc with @pierreablin ASAP
|
CIs show some package conflicts (traits) - do we fix these before merging? |
|
I would suggest to update with |
|
@sappelhoff can you rebase? |
|
Alright, now seeing the errors described in #8040. Any ideas? |
|
I compared with a recently merged PR and 5 days ago: https://travis-ci.org/github/mne-tools/mne-python/jobs/709093476#L909 |
|
Probably. But which package is causing this runtime error then? There is no |
|
Testing in #8042. |
|
You mean they might have overlooked the dependency on |
|
It's just a guess since it's the first big change I notice. But this could explain why there is no error during installation. |
|
Yes. And according to https://docs.enthought.com/pyface/changelog.html#release-7-0-1, |
|
|
|
Some package apparently pins |
|
Maybe someone who actually knows what they are doing could help, because I don't use |
|
Great move, @sappelhoff! @agramfort was waiting for somebody to step in and finally file this kind of PR ;) Good to see this happen!! We've been using Picard in my old lab and it worked really well. It's also our default now in the |
Update mne/preprocessing/ica.py Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
|
thx @sappelhoff |

Picard can be used to obtain the same solution as with FastICA, Infomax, or extended Infomax --> and apparently (according to Picard 😉 ) converges faster.
This sounds like a win for me, so I added this to the docs. WDYT?
@larsoner @cbrnr @agramfort @mmagnuski @pierreablin
Info taken from README: https://github.com/pierreablin/picard
Previously discussed in gitter, Thanks @cbrnr for making me aware of it.