Skip to content

Conversation

@larsoner
Copy link
Member

plot_source_estimates and plot_vector_source_estimates share 90%+ of their code. This unifies the two approaches into a single _plot_stc function.

This will make things like #8064 much easier, as instead of making deep changes in two places, you can make them in one.

@agramfort
Copy link
Member

@GuillaumeFavelier i let you merge if happy

@GuillaumeFavelier GuillaumeFavelier merged commit 000dac9 into mne-tools:master Jul 29, 2020
@GuillaumeFavelier
Copy link
Contributor

Thank you @larsoner !

@larsoner larsoner deleted the unify branch July 29, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants