MRG, API: prep for to_data_frame default argument change #8298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
MRG?
… |
drammock
changed the title
Member
Author
Yes, sorry, forgot to add that. |
agramfort
approved these changes
Sep 23, 2020
Member
|
@drammock any phantasy how that might interact downstream with R stuff? |
Member
Author
some MNE-R tests will definitely start failing once the default changes, which won't happen in MNE-Python stable for ~1 year. Hopefully before then one of us will take a fresh look at MNE-R and its test suite... the update to R 4.0 changed the |
Member
|
Ok sounds good! I want to defnitely spend a few days on this before the end of the year. I'll ping you once I have an idea when that could be. Perhaps we can coordinate a bit. |
Member
|
Thanks @drammock |
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crossref #7206 (especially this comment)
The goal is to change default from
'ms'toNone. In this PR I'm only changing docstring, not raising a warning if the current default is passed. I suppose I could change the default toNoneand haveNonetemporarily mean'ms', and add temporarily a valid argument's'to get the behavior currently intended byNone, and raise a warning if the value isNonerather than's'or'ms'? But at least some people have learned that explicitly passingNoneis what they should do (e.g., #8044) so IMO raising a warning in that way would cause more confusion than it might avert.