Backport: Fix backend='pyvista' in stc.plot() (#8395)

[hoechenberger]

No description provided.

[hoechenberger]

I'm not sure why the notebook test fails… @GuillaumeFavelier mind having a look?

[hoechenberger]

@agramfort One test failed, yet you merged this PR – was this intentional or an accident?

[agramfort]

yes it's intentional. I did not think the issue was related. Was it?

…

[GuillaumeFavelier]

Yes. But it's just a small thing. On maint/0.21.0 the attribute name is _notebook (with an underscore) instead of just notebook

[hoechenberger]

@GuillaumeFavelier

Yes. But it's just a small thing. On maint/0.21.0 the attribute name is _notebook (with an underscore) instead of just notebook

But this PR didn't touch any of these… I don't get it. But you seem to be understanding what's going on :) I'd appreciate if you could file a follow-up PR if something is broken now? Or we can have a quick chat / call and you tell me what I need to fix :)
btw check your Slack! ;)

[agramfort]

oups my bad....

…

[GuillaumeFavelier]

But this PR didn't touch any of these…

The tests use the name 😅

I will open a PR that reverts to the old name and we backport it too. What do you say?

[hoechenberger]

I will open a PR that reverts to the old name and we backport it too. What do you say?

perfect :) file the PR against the maint/0.21 branch directly