Skip to content

Conversation

@kdoelling1919
Copy link
Contributor

Reference issue

Issue #8445

What does this implement/fix?

Reduce maximum alpha to be 0.75 in plot_alignment to aid viewing of electrodes inside the brain and skull (mostly sEEG). Also edits a few tutorials to see the new outputs of circleCI

Additional information

The goal currently is to see how these look in the tutorial examples so that we can decide whether this is the best strategy or to use an autodetect (of whether sensors are inside the surface) method instead.

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

@larsoner
Copy link
Member

@kdoelling1919 let me know once you've checked the outputs and they look okay (bonus points if you paste CircleCI links here so that it's easier for me to look, too). Other than one minor gripe, LGTM.

@GuillaumeFavelier what would it take to add a depth_peeling argument to plot_alignment? I think we probably want it for at least some plots. It should probably be another PR, but I suspect it would make at least some of these plots look better.

Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
@agramfort
Copy link
Member

agramfort commented Oct 31, 2020 via email

@kdoelling1919
Copy link
Contributor Author

Here's what it looks in current version
https://mne.tools/dev/auto_tutorials/misc/plot_seeg.html#sphx-glr-auto-tutorials-misc-plot-seeg-py

The only difference is that I added the pial surface to show that it can be done with the transparency. It looks fine to me but maybe could be improved by changing the viewing angle?

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good !


Enhancements
~~~~~~~~~~~~
- Update ``surfaces`` argument in :func:`mne.viz.plot_alignment` to allow dict for transparency values, and set default for sEEG data to have transparency (by `Keith Doelling`_ (:gh:`8445`))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Update ``surfaces`` argument in :func:`mne.viz.plot_alignment` to allow dict for transparency values, and set default for sEEG data to have transparency (by `Keith Doelling`_ (:gh:`8445`))
- Update ``surfaces`` argument in :func:`mne.viz.plot_alignment` to allow dict for transparency values, and set default for sEEG data to have transparency (by `Keith Doelling`_ (:gh:`8445`)

But we can fix this later, we're probably reformatting all of these lines within this release anyway

@larsoner larsoner merged commit 67d5013 into mne-tools:master Oct 31, 2020
@larsoner
Copy link
Member

Thanks @kdoelling1919 !

@kdoelling1919
Copy link
Contributor Author

great success! Thanks to everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants