-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[WIP] Add transparency to plot_alignment #8446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
|
@kdoelling1919 let me know once you've checked the outputs and they look okay (bonus points if you paste CircleCI links here so that it's easier for me to look, too). Other than one minor gripe, LGTM. @GuillaumeFavelier what would it take to add a |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
|
Looks good except for now you can see one of the depth electrodes didn't really hit the brain... Other tutorials that used plot_alignment seem to be in tact. |
|
Here's what it looks in current version The only difference is that I added the pial surface to show that it can be done with the transparency. It looks fine to me but maybe could be improved by changing the viewing angle? |
agramfort
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good !
|
|
||
| Enhancements | ||
| ~~~~~~~~~~~~ | ||
| - Update ``surfaces`` argument in :func:`mne.viz.plot_alignment` to allow dict for transparency values, and set default for sEEG data to have transparency (by `Keith Doelling`_ (:gh:`8445`)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Update ``surfaces`` argument in :func:`mne.viz.plot_alignment` to allow dict for transparency values, and set default for sEEG data to have transparency (by `Keith Doelling`_ (:gh:`8445`)) | |
| - Update ``surfaces`` argument in :func:`mne.viz.plot_alignment` to allow dict for transparency values, and set default for sEEG data to have transparency (by `Keith Doelling`_ (:gh:`8445`) |
But we can fix this later, we're probably reformatting all of these lines within this release anyway
|
Thanks @kdoelling1919 ! |
|
great success! Thanks to everyone! |
Reference issue
Issue #8445
What does this implement/fix?
Reduce maximum alpha to be 0.75 in plot_alignment to aid viewing of electrodes inside the brain and skull (mostly sEEG). Also edits a few tutorials to see the new outputs of circleCI
Additional information
The goal currently is to see how these look in the tutorial examples so that we can decide whether this is the best strategy or to use an autodetect (of whether sensors are inside the surface) method instead.