Skip to content

Conversation

@hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Nov 6, 2020

This should fix the error on Circle

@hoechenberger hoechenberger changed the title FIX #8486, Evoked and Epochs don't get split [MRG] FIX #8486, Evoked and Epochs don't get split Nov 6, 2020
@hoechenberger
Copy link
Member Author

One Travis run times out, but the other one is genuinely failing. I'm not sure what's happening, I cannot reproduce. It appears there's a side-effect somewhere, altering raw_fname??

@hoechenberger
Copy link
Member Author

@larsoner any idea?

@larsoner
Copy link
Member

larsoner commented Nov 6, 2020

https://github.com/mne-tools/mne-python/blob/master/mne/tests/test_report.py#L499

is missing the @testing.requires_testing_data decorator

@hoechenberger
Copy link
Member Author

D'oh!

@larsoner larsoner mentioned this pull request Nov 6, 2020
@larsoner larsoner merged commit b9a7fb7 into mne-tools:master Nov 6, 2020
@hoechenberger hoechenberger deleted the fix-report-split-handling branch November 6, 2020 14:53
@larsoner
Copy link
Member

larsoner commented Nov 6, 2020

Thanks @hoechenberger

In the future when there is an error on CircleCI, it's good practice to make some minor change to the example in the PR that is supposed to fix it. That way in the PR we can see that the example runs without issue. (CircleCI for PRs only builds changed examples by default.)

@hoechenberger
Copy link
Member Author

Got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants