Skip to content

Fixing missing info for some templates #8869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 3 commits into from
Feb 22, 2021
Merged

Fixing missing info for some templates #8869

larsoner merged 3 commits into from
Feb 22, 2021

Conversation

@christian-oreilly
Copy link
Contributor

@christian-oreilly christian-oreilly commented Feb 13, 2021 •
edited
Loading

What does this implement/fix?

Fixing missing info for the 2mo and the 18mo templates.

Example of bug this solves:

mne.datasets.fetch_infant_template("18mo"

---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-7-4ce04742900f> in <module>
----> 1 mne.datasets.fetch_infant_template("18mo", subjects_dir=subjects_dir)

<decorator-gen-485> in fetch_infant_template(age, subjects_dir, verbose)

~/code/mne-python/mne/datasets/_infant/base.py in fetch_infant_template(age, subjects_dir, verbose)
     90         destination=subj_dir,
     91         url=_ORIGINAL_URL.format(subject=subject),
---> 92         hash_=orig_hashes[f'{subject}.zip'],
     93     )
     94     return subject

KeyError: 'ANTS18-0Months3T.zip'

@christian-oreilly
Fixing missing info for some templates
ff1e4ab 
Fixing missing info for the 2mo and the 18mo templates
larsoner
larsoner reviewed Feb 17, 2021
View reviewed changes
larsoner
larsoner reviewed Feb 17, 2021
View reviewed changes
mne/datasets/_infant/base.py Outdated
----------
age : str
Age to download. Can be one of ``{'2wk', '1mo', '3mo', '4.5mo', '6mo',
Age to download. Can be one of ``{'2wk', '1mo', '2mo', '3mo', '4.5mo', '6mo',
Copy link
Member

@larsoner larsoner Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long

@larsoner larsoner merged commit b487dcf into mne-tools:main Feb 22, 2021
@larsoner
Copy link
Member

larsoner commented Feb 22, 2021

Thanks @christian-oreilly !

marsipu pushed a commit to marsipu/mne-python that referenced this pull request Feb 25, 2021
@christian-oreilly @larsoner @marsipu
Fixing missing info for some templates (mne-tools#8869)
71e90e7 
* Fixing missing info for some templates

Fixing missing info for the 2mo and the 18mo templates

* Adding missing ANTS2-0Months3T.txt file.

* STY: Flake

Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christian-oreilly @larsoner