-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG, ENH: Allow channel-specific annotations #8896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Okay I think this is good to go now |
|
LGTM +1 for merge when green! |
hoechenberger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
|
@larsoner The CI error seems unrelated to me! |
|
Thank you, @larsoner! |
* ENH: Allow channel-specific annotations * FIX: rename, drop, example, doc * DOC: Clarify
|
Is this only for the most recent version of python? I do not seem to have this functionality in python 3.6 even though I am up to date with mne. |
|
The latest development version and the upcoming release of MNE-Python 0.24 only support Python 3.7 and newer. |
|
I have updated everything and the annotations recognize ch_names as input, but they do not actually annotate specific channels. Do the channels need to have specific names as strings? |
so far this feature has no effect when plotting (we plan to do that, but it's not done yet). Is that what you're noticing? |
|
That is what I am noticing. Would I be able to see the channel specific annotations if I save and open in another program? |
I think SigViewer has the ability to display channel-specific annotations. I don't know if SigViewer can read our |
|
Thank you. |
|
Yes, SigViewer should be able to import events from a CSV file with columns position, duration, channel, type, and name. A channel value of -1 means all channels. However, I just tried this with a dummy file and the import didn't work (but there was no error either), so I guess this functionality is currently broken 😢 . |
|
Just wondering if there has been any progress on displaying per-channel annotations? |
|
Not that I've seen |
@britta-wstnr good one for the fall sprint? |
|
Chiming in to say that I would very much appreciate this feature as well. |
|
I just realized that visualization of channel-specific annotations has actually been implemented in mne-qt-browser, so I'm posting here again for the benefit of everyone that didn't find the respective issues and pull requests, but did find this pull request (as I had initially).
|

Closes #5507
Removes some heavy, seemingly overkill parametrization of the
test_annotations.pywhere the parameters were only used in a single function for example. Also makes anoverwriteentry indocdict.Todo:
rename_channelschange the names inannotationsdrop_channelsdrop channel names, and channel-specific annotations that no longer apply