Skip to content

Conversation

@drammock
Copy link
Member

closes #8893

@drammock drammock changed the title easiest fix ever VIZ, FIX: make annotations immediately visible when scrolling via click on scrollbar Feb 23, 2021
@drammock drammock requested a review from cbrnr February 23, 2021 00:00
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The elusive one-line fix!

@cbrnr
Copy link
Contributor

cbrnr commented Feb 23, 2021

I assume the failing tests are unrelated? Some of them are raw.plot tests though. Otherwise LGTM (tested and it works)!

@larsoner
Copy link
Member

I assume the failing tests are unrelated?

Yeah they are failing on every PR, and I checked that at least the number of failures is the same here as in other PRs for the linux pip build

@larsoner larsoner merged commit 9b01f00 into mne-tools:main Feb 23, 2021
@larsoner
Copy link
Member

Thanks @drammock

@cbrnr cbrnr added the backport-candidate on-merge: backport to maint/1.11 label Feb 23, 2021
@cbrnr
Copy link
Contributor

cbrnr commented Feb 23, 2021

Thanks @drammock - could you backport this PR?

drammock added a commit to drammock/mne-python that referenced this pull request Feb 23, 2021
drammock added a commit that referenced this pull request Feb 23, 2021
@drammock drammock added backported and removed backport-candidate on-merge: backport to maint/1.11 labels Feb 23, 2021
@drammock drammock deleted the fix-raw-scroll-annotations branch February 23, 2021 14:41
marsipu pushed a commit to marsipu/mne-python that referenced this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking in overview bar does not draw annotations in raw.plot

3 participants