Skip to content

Conversation

@bloyl
Copy link
Contributor

@bloyl bloyl commented Feb 26, 2021

What does this implement/fix?

ica.exclude = [0]
ica.plot_sources(raw, picks=[1, 2])

would raise an exception.

RuntimeError: bad channel(s) ['ICA000'] marked do not exist in info

Also fixed a typo in ctf.io

I don't think either of these have made it to release so no whats new.

closes #8966

@bloyl bloyl requested a review from drammock February 26, 2021 19:06
@larsoner
Copy link
Member

Just a heads up that the pip 3.9 and pip pre builds are broken currently, feel free to ignore them

@drammock
Copy link
Member

@drammock
Copy link
Member

The example looks correct now: https://25473-1301584-gh.circle-artifacts.com/0/dev/auto_examples/preprocessing/plot_run_ica.html#sphx-glr-auto-examples-preprocessing-plot-run-ica-py

But I don't think the change to the test file is actually testing what we want it to, so don't merge until after I've updated that (off to a meeting now)

@bloyl
Copy link
Contributor Author

bloyl commented Feb 26, 2021

Sorry I should have been clearer. My commits were intended to just fix the behavior in the PR description and in the test, not the issue opened (#8966).

Your commits seem to close that issue as well. Thanks!

@drammock
Copy link
Member

Sorry I should have been clearer.

I think this was a case of me not reading carefully enough :)

Anyway I think now both problems are fixed.

@drammock drammock merged commit 6f64726 into mne-tools:main Feb 26, 2021
@drammock
Copy link
Member

thanks @bloyl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ica.plot_sources ignores ica_names if picks is used

3 participants