Skip to content

Conversation

@GuillaumeFavelier
Copy link
Contributor

This PR fixes the issue with:

Traceback (most recent call last):
  File "/home/circleci/project/mne/viz/_brain/_brain.py", line 50, in safe_event
    return fun(*args, **kwargs)
  File "/home/circleci/project/mne/viz/_brain/_brain.py", line 690, in _clean
    self.clear_glyphs()
  File "/home/circleci/project/mne/viz/_brain/_brain.py", line 1701, in clear_glyphs
    self.rms.remove()
TypeError: remove() takes exactly one argument (0 given)

@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 1, 2021
@larsoner
Copy link
Member

larsoner commented Mar 1, 2021

Could we update a test that would have caught this?

@larsoner
Copy link
Member

larsoner commented Mar 1, 2021

I'll merge this to get things green in main but a test at some point would be good!

@larsoner larsoner merged commit 22ea75b into mne-tools:main Mar 1, 2021
@GuillaumeFavelier
Copy link
Contributor Author

GuillaumeFavelier commented Mar 1, 2021

Some tests crashed but the TypeError has been raised in test_single_hemi:

Traceback (most recent call last):
  File "/home/runner/work/mne-python/mne-python/mne/viz/_brain/_brain.py", line 1219, in _set_annot
    self.clear_glyphs()
  File "/home/runner/work/mne-python/mne-python/mne/viz/_brain/_brain.py", line 1701, in clear_glyphs
    self.rms.remove()
TypeError: remove() takes exactly one argument (0 given)

https://github.com/mne-tools/mne-python/runs/1993712050#step:13:3006

larsoner added a commit to GuillaumeFavelier/mne-python that referenced this pull request Mar 1, 2021
larsoner added a commit to marsipu/mne-python that referenced this pull request Mar 1, 2021
* upstream/main:
  MAINT: Skip matplotlib pre for now (mne-tools#8973)
  FIX: Brain lights (mne-tools#8972)
  MNT: Migrate VTK Widgets (mne-tools#8862)
  Fix (mne-tools#8971)
  Fix indexing dipoles read from a bdip file (mne-tools#8963)
larsoner added a commit to adam2392/mne-python that referenced this pull request Mar 1, 2021
* upstream/main:
  MAINT: Skip matplotlib pre for now (mne-tools#8973)
  FIX: Brain lights (mne-tools#8972)
  MNT: Migrate VTK Widgets (mne-tools#8862)
  Fix (mne-tools#8971)
larsoner added a commit to bloyl/mne-python that referenced this pull request Mar 1, 2021
* upstream/main:
  MAINT: Skip matplotlib pre for now (mne-tools#8973)
  FIX: Brain lights (mne-tools#8972)
  MNT: Migrate VTK Widgets (mne-tools#8862)
  Fix (mne-tools#8971)
  Fix indexing dipoles read from a bdip file (mne-tools#8963)
@GuillaumeFavelier GuillaumeFavelier deleted the brain/fix branch March 3, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants