-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG, BUG: Fix interactive update of mapping #8985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
we could check that |
Great idea, pushed. Will merge and backport once CIs come back happy |
|
Okay I fought through a bit of a nightmare with control flow with LUT updates. Now:
This also makes interaction smoother for me, which is nice. Ready for review/merge from my end @GuillaumeFavelier, hopefully CIs come back happy with this one... |
|
Actually I think I realized a simpler pattern, will implement it tomorrow |
|
Okay @GuillaumeFavelier should be good to go here |
GuillaumeFavelier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it is indeed very snappy now 👍
|
Thanks @larsoner ! |
On
main:Peek.2021-03-03.12-05.mp4
On this PR:
Peek.2021-03-03.12-05_2.mp4
I don't know a good wait to test this on CIs unfortunately since it has to do with actual rendering.