Skip to content

MNT: 3d viewer loc and idx #8998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 1 commit into from
Mar 5, 2021
Merged

MNT: 3d viewer loc and idx #8998

larsoner merged 1 commit into from
Mar 5, 2021

Conversation

@GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Mar 5, 2021

This small PR should help with #8997. It refactors some plotter calls out of Brain and uses self.figure instead.

@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 5, 2021
larsoner
larsoner approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM feel free to merge once CIs come back happy @GuillaumeFavelier

@larsoner larsoner merged commit 4cecd9d into mne-tools:main Mar 5, 2021
@larsoner
Copy link
Member

larsoner commented Mar 5, 2021

Thanks @GuillaumeFavelier

@GuillaumeFavelier GuillaumeFavelier deleted the mnt/loc_and_idx branch March 5, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner approved these changes

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeFavelier @larsoner