Skip to content

MNT: menu_bar & status_bar #9014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GuillaumeFavelier merged 7 commits into from
Mar 9, 2021
Merged

MNT: menu_bar & status_bar #9014

GuillaumeFavelier merged 7 commits into from
Mar 9, 2021

Conversation

@GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Mar 9, 2021 •
edited
Loading

This PR disables the default menu bar created by PyVistaQt and uses the _QtMenuBar interface instead.

It also helps with #8997

@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 9, 2021
@GuillaumeFavelier
Copy link
Contributor Author

GuillaumeFavelier commented Mar 9, 2021

I'll work on a _QtStatusBar interface too.

@GuillaumeFavelier GuillaumeFavelier changed the title MNT: menu_bar WIP, MNT: menu_bar & status_bar Mar 9, 2021
@GuillaumeFavelier GuillaumeFavelier changed the title WIP, MNT: menu_bar & status_bar MNT: menu_bar & status_bar Mar 9, 2021
@GuillaumeFavelier
Copy link
Contributor Author

GuillaumeFavelier commented Mar 9, 2021

It's good to go on my end. I'm waiting for the CIs.

larsoner
larsoner reviewed Mar 9, 2021
View reviewed changes
@GuillaumeFavelier
Copy link
Contributor Author

GuillaumeFavelier commented Mar 9, 2021

the idea is that any special-casing based on backend functionality can be made just based on which backend class is called

I'll improve the situation on the following PR

larsoner
larsoner approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge once CIs come back happy!

@GuillaumeFavelier GuillaumeFavelier merged commit 97a69e6 into mne-tools:main Mar 9, 2021
@GuillaumeFavelier GuillaumeFavelier deleted the mnt/menu_bar branch March 9, 2021 13:29
@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner approved these changes

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeFavelier @larsoner