Skip to content

Conversation

@GuillaumeFavelier
Copy link
Contributor

This PR refactors MplCanvas so that canvas not related to Brain can be created. For instance, the help window:

output.mp4

It's an item of #8704

@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 17, 2021
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for MRG if CI are green

video was convincing for me :)

@GuillaumeFavelier GuillaumeFavelier merged commit 5f0beb9 into mne-tools:main Mar 17, 2021
@GuillaumeFavelier GuillaumeFavelier deleted the enh/help_button branch March 17, 2021 14:03
@GuillaumeFavelier
Copy link
Contributor Author

Thanks for review and testing @agramfort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants