Skip to content

ENH: Add Evoked.baseline #9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hoechenberger merged 3 commits into from
Mar 30, 2021
Merged

ENH: Add Evoked.baseline #9210

hoechenberger merged 3 commits into from
Mar 30, 2021

Conversation

@hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Mar 28, 2021

Fixes #8334

@hoechenberger hoechenberger reopened this Mar 29, 2021
@hoechenberger hoechenberger reopened this Mar 29, 2021
@hoechenberger hoechenberger reopened this Mar 29, 2021
@hoechenberger hoechenberger force-pushed the hoechenberger/issue8334 branch from f4437a6 to 9ed2040 Compare March 29, 2021 17:01
@hoechenberger hoechenberger marked this pull request as ready for review March 29, 2021 17:02
@hoechenberger hoechenberger changed the title WIP: Add Evoked.baseline ENH: Add Evoked.baseline Mar 29, 2021
@hoechenberger
Copy link
Member Author

hoechenberger commented Mar 29, 2021

This is ready for review. The PR adds an Evoked.baseline attribute, which is derived from Epochs.baseline during averaging.

@hoechenberger
Copy link
Member Author

hoechenberger commented Mar 29, 2021

Tutorials look good:
https://26611-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/evoked/plot_10_evoked_overview.html
https://26611-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/evoked/plot_20_visualize_evoked.html

(search for "baseline")

larsoner
larsoner reviewed Mar 29, 2021
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

mne/tests/test_evoked.py
baseline = (-0.2, -0.1)
evoked.apply_baseline(baseline)
with pytest.raises(ValueError, match='already been baseline-corrected'):
evoked.apply_baseline(None)
Copy link
Member

@larsoner larsoner Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a assert evoked.baseline is None in any of these tests, can you add a test that no baseline gets this?

Copy link
Member Author

@hoechenberger hoechenberger Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I've added a few more test cases in 21d5514

larsoner
larsoner approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 for merge

@hoechenberger hoechenberger merged commit 53a8634 into mne-tools:main Mar 30, 2021
@hoechenberger hoechenberger deleted the hoechenberger/issue8334 branch March 30, 2021 06:44
@cbrnr cbrnr mentioned this pull request May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Evoked.baseline

2 participants

@hoechenberger @larsoner