BUG: Fix coordinate frame #9251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Apr 5, 2021
Member
agramfort
left a comment
agramfort
left a comment
There was a problem hiding this comment.
+1 for MRG provided @christianbrodbeck confirms it fixes the pb and we have a what's new entry.
thx heaps @larsoner !
hoechenberger
approved these changes
Apr 5, 2021
Member
Author
Quoting above:
|
Member
|
ok then. Let's just make CIs green :) |
Member
Author
|
Failure was just a timeout but it actually passed: so I'll go ahead and merge |
vagechirkov
pushed a commit
to vagechirkov/mne-python
that referenced
this pull request
Apr 6, 2021
* BUG: Fix coordinate frame * FIX: Better test * FIX: Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@christianbrodbeck see #9250, this PR fixes the behavior in
main:To properly transform to the head coordinate frame (this PR):
No need for latest.inc update because this was added within-cycle in #8789
Closes #9250