Skip to content

Conversation

@GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Apr 19, 2021

It seems that #8852 was not enough. I'll investigate the issue thoroughly in here and come back to #9010 afterwards.

Progress:

  • Fix "minimized" issue
  • Fix update issue

ToDo:

  • Touch example as baseline
  • Revert qt_disable_paint
  • Investigate set_3d_view

Related to #9010 (comment), #8828

@GuillaumeFavelier GuillaumeFavelier self-assigned this Apr 19, 2021
@larsoner larsoner added this to the 0.23 milestone Apr 19, 2021
@larsoner
Copy link
Member

Also can you check that tutorials/sample-datasets/plot_phantom_4DBTi.py plots correctly in this PR (make some change to it)? On my system the first plot looks like:

Screenshot from 2021-04-19 08-55-59

And if I click-drag anywhere it gets fixed:

Screenshot from 2021-04-19 08-56-03

So it seems to just be some update problem here, too.

@GuillaumeFavelier
Copy link
Contributor Author

I'll add it to the list

@GuillaumeFavelier
Copy link
Contributor Author

GuillaumeFavelier commented Apr 19, 2021

@larsoner
Copy link
Member

Can you reproduce locally with PATTERN=source_alignment make html_dev-pattern? That way you won't have to wait for CircleCI (and use up its cycles).

Some hint at the problem is perhaps that the plain plot_alignment calls are bad, but the one that changes the view looks good. So somehow that view-setting call fixes things.

@GuillaumeFavelier
Copy link
Contributor Author

I tried and I do not reproduce with my usual desktop manager. A similar environment is probably building on a TTY with a running xvfb though.

@GuillaumeFavelier
Copy link
Contributor Author

@GuillaumeFavelier
Copy link
Contributor Author

@GuillaumeFavelier GuillaumeFavelier changed the title WIP,FIX: paintEvent/resizeEvent WIP,FIX: paintEvent/resizeEvent & update Apr 19, 2021
@GuillaumeFavelier GuillaumeFavelier changed the title WIP,FIX: paintEvent/resizeEvent & update FIX: paintEvent/resizeEvent & update Apr 19, 2021
@larsoner
Copy link
Member

@GuillaumeFavelier we are also seeing some problems on CircleCI for main:

Traceback (most recent call last):
  File "/home/circleci/.local/lib/python3.8/site-packages/sphinx_gallery/scrapers.py", line 333, in save_figures
    rst = scraper(block, block_vars, gallery_conf)
  File "/home/circleci/.local/lib/python3.8/site-packages/pyvista/utilities/sphinx_gallery.py", line 49, in __call__
    plotter.screenshot(fname)
  File "/home/circleci/.local/lib/python3.8/site-packages/pyvista/plotting/plotting.py", line 3122, in screenshot
    return self._save_image(self.image, filename, return_img)
  File "/home/circleci/.local/lib/python3.8/site-packages/vtkmodules/qt/QVTKRenderWindowInteractor.py", line 335, in __getattr__
    raise AttributeError(self.__class__.__name__ +
AttributeError: BackgroundPlotter has no attribute named image

Is this a PyVista bug with their scraper?

@GuillaumeFavelier
Copy link
Contributor Author

Is this a PyVista bug with their scraper?

Hm... probably 🤔

@GuillaumeFavelier
Copy link
Contributor Author

I'm still trying to figure out where this comes from. AFAIK, self.image is a property of BasePlotter, I don't understand why the scraper complains.

@larsoner
Copy link
Member

Okay well I'll merge this once CIs come back happy, feel free to open a new PR for that error

@GuillaumeFavelier
Copy link
Contributor Author

Will do

@larsoner
Copy link
Member

Thanks @GuillaumeFavelier !

@GuillaumeFavelier GuillaumeFavelier deleted the fix/paintEvent branch April 19, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants