[MRG, DOC] Remove CSD average reference note #9320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think the tests should pass and be the same because the test data was already in average reference. |
alexrockhill
changed the title
Contributor
Author
|
Ok, once the tests pass, this should be good to go. It just clarifies that the data does not need to be average referenced to apply the CSD by removing a comment that said that the data would be automatically average referenced. |
alexrockhill
changed the title
alexrockhill
changed the title
Contributor
Author
|
Doesn't look like the test failures are legitimate, I think this is good to go |
agramfort
approved these changes
Apr 20, 2021
Member
|
Thanks @alexrockhill |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Apr 20, 2021
* upstream/main: MNT: BackgroundPlotter has no attribute named image (mne-tools#9318) [MRG, DOC] Remove CSD average reference note (mne-tools#9320)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9319