MAINT: Check name URLs #9323
Merged
MAINT: Check name URLs #9323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@agramfort feel free to merge if you're happy with the URLs. I basically tried to find a personal url; then a current research-group-page url; then a GitHub URL. |
drammock
approved these changes
Apr 20, 2021
Member
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
looks reasonable. I didn't know mark had moved to JPL!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't check anyone's
names.incURLs but we should. This adds a little extension that outputs agenerated/_names.rstwhen using the linkcheck builder.I see some failures locally with the check so I'll push that first to make sure we see it on CIs, then I'll add another commit to fix them.