fix epochs vlines #9326
Merged
fix epochs vlines #9326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
approved these changes
Apr 21, 2021
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
LGTM +1 for merge. @jasmainak @agramfort one of you will have to test this fix since I can't replicate the issue on my machine
jasmainak
approved these changes
Apr 21, 2021
Member
jasmainak
left a comment
jasmainak
left a comment
There was a problem hiding this comment.
I tried my best to break it but it survived all such attempts :)
Member
|
I did notice a slower response but okay to fix it later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9276 (supersedes)
In order to get this fixed before release time, I've removed the blitting code. This slows down vline drawing (esp. in butterfly mode, where it can take up to a few seconds) but at least now the bug is fixed. I'll try to restore the blitting after release, when there is more time for testing.
@jasmainak can you test?