[ENH] add exclude kw to psd_plot #9379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
thx @eort can you see why CIs fail? |
Contributor
Author
Yeah, I guess so (see last commit) |
Member
|
I am getting that same Linux 3.8 CI fine cal error in #9375. |
larsoner
reviewed
May 10, 2021
Contributor
Author
|
Looks good to me! As I simply copied the code from the erp.plot(), should I port the suggested change here, to that function as well? |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Member
|
What's the status here? This should be almost good to go after a rebase / merging |
Contributor
Author
|
Not sure. I think the last commit was "ready", but I guess it was forgotten. |
Member
|
Sorry about that, @eort! Let's revive this. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with this comment in #1234.
What does this implement/fix?
This PR adds the
excludekeyword toraw.plot_psd()andepochs.plot_psd(). I essentially copied the exclude functionality fromevoked.plot()to_psd_figure.pyand fixed up the dependencies. Also two tests were added.Additional information
pytest viz/tests/test_figure.pyfailed on my system, but it also did so on the main branch, so I don't think it is related to the changes.