Skip to content

Conversation

@rob-luke
Copy link
Member

What does this implement/fix?

Enables interpolation on all fNIRS types using the new and more generic _validate_nirs_info function.

@rob-luke rob-luke changed the title WIP: Enable interpolation for all fNIRS types MRG: Enable interpolation for all fNIRS types May 29, 2021
@rob-luke
Copy link
Member Author

@agramfort @larsoner could you please review

@agramfort agramfort merged commit f42f612 into mne-tools:main May 29, 2021
@agramfort
Copy link
Member

thx @rob-luke

@rob-luke rob-luke deleted the interpolatenirs branch May 29, 2021 08:49
larsoner added a commit to larsoner/mne-python that referenced this pull request Jun 2, 2021
* upstream/main:
  [MRG] change utils.logger.warning -> utils.warn (mne-tools#9434)
  FIX : rank computation from info now uses SSS proc history if only grad or mag are present (mne-tools#9435)
  MRG: Enable interpolation for all fNIRS types (mne-tools#9431)
  FIX: brain save_movie (mne-tools#9426)
  ENH: Add mne.export (mne-tools#9427)
  ENH: Test more on pre [skip circle] (mne-tools#9423)
  MRG, ENH: Speed up brain test (mne-tools#9422)
  MAINT: Update URL [ci skip]
  MNT: Reduce number of calls to _update (mne-tools#9407)
  MRG: Tutorial improvements (mne-tools#9416)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants