use Polynomial.fit for poly fitting #9514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM, can you add a |
drammock
reviewed
Jul 1, 2021
Contributor
Author
|
Yup, I will add a latest.inc entry. Q: I see the mne-tools.mne-python check failed because of timing out, but from the error message I don't understand why it took so long. What's up with that? |
Member
|
That build times out but that should be fixed by #9518. If you rebase or merge your branch with upstream/main it should be fixed |
agramfort
approved these changes
Jul 2, 2021
Member
|
Thanks @nordme ! |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Jul 6, 2021
* upstream/main: MAINT: Avoid VTK 9.0.2 [skip actions] [skip circle] (mne-tools#9530) MRG: Test get_montage on fNIRS data (mne-tools#9524) FIX: fix topo plot when large channel distance gives rise to invalid values for arcsin (mne-tools#9528) use Polynomial.fit for poly fitting (mne-tools#9514)
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Jul 6, 2021
* upstream/main: MRG, ENH: Abstracted volume registration again (mne-tools#9521) MAINT: Avoid VTK 9.0.2 [skip actions] [skip circle] (mne-tools#9530) MRG: Test get_montage on fNIRS data (mne-tools#9524) FIX: fix topo plot when large channel distance gives rise to invalid values for arcsin (mne-tools#9528) use Polynomial.fit for poly fitting (mne-tools#9514)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@larsoner np.polyfit was deprecated when I tried to use the realign function to sync our eeg / meg data. This is an update to use the Polynomial.fit method suggested by Numpy in the deprecation warning. Take a look and see what you think.