Add get_data method to Evoked #9555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
larsoner
requested changes
Jul 13, 2021
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Needs latest.inc update and a versionadded would be good, otherwise LGTM!
larsoner
approved these changes
Jul 13, 2021
Member
|
pip pre failure is numpy/numpy#19469 and we can ignore it for now |
agramfort
approved these changes
Jul 13, 2021
Member
|
thanks @sappelhoff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9244
working on #9553 I thought I'd give this a shot as well. Please let me know what I should add - I can add the
unitsparameter here or in #9553, depending on which one gets merged earlier.EDIT: the tmin/tmax params from #9548 could also be added here.better in #9556To Do