[ENH, MRG] Fix find aseg for Dipole #9579
Conversation
|
Do you need |
|
(in other words, assume YAGNI until proven otherwise) |
|
It's in the dipole tutorial that uses This can be closed without merging but I made the changes and was going to keep it open for a minute until the issue is resolved or we just say it's not a big deal. I think it's actually a pretty big liability though because the coordinate frames are not that easy to understand. |
alexrockhill
changed the title
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
@mdovgialo is this API change okay with you?
|
Weird, the test passes locally for me and it hasn't been effected by the changes... |
|
And it passed before I fixed the licenses... |
I'm fine with this |
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Other than the naming issue we should be good here, the failure is unrelated
* upstream/main: [MRG, ENH] Find aseg labels near montage (mne-tools#9545) Add label to colorbar in GAT plot [skip actions] (mne-tools#9582) [ENH, MRG] Encapsulate warp elec image in function (mne-tools#9544) [DOC, MRG] Add "info" to `docdict` (mne-tools#9574) [MRG] Add `units` parameter to get_data for Evoked (mne-tools#9578) [MRG, ENH] Get annotation description from snirf stim name (mne-tools#9575) [MRG] ENH, FIX: Add tmin/tmax parameters to get_data methods, fix bug in find_bads_ecg (mne-tools#9556)
|
Looks good to me :) |
4 participants
Fixes #9577.
#9545 does this for
DigMontages and so I think the only use case for this isDipoles. There is already ato_mnifunction, I think there should just be anto_asegfunction as well, that makes sense to me.