Skip to content

Conversation

@rezashr
Copy link
Contributor

@rezashr rezashr commented Sep 2, 2021

Reference issue

Fixes #9380
Improves #9381

What does this implement/fix?

With #9381, 'ceo' files can be imported after renaming to 'cef'. This PR adds '.ceo' extension to event file extensions.

@welcome
Copy link

welcome bot commented Sep 2, 2021

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DiGyt ok for you?

@larsoner
Copy link
Member

larsoner commented Sep 2, 2021

@rezashr can you add an entry to doc/changes/latest.inc in the enhancements section?

@rezashr
Copy link
Contributor Author

rezashr commented Sep 2, 2021

@larsoner there was an entry for reading '.cdt.ceo' events in latest.inc, so I merged this PR description to that one. Is it okay?

@larsoner
Copy link
Member

larsoner commented Sep 3, 2021

@rezashr I think you just need to add your name+URL to doc/changes/names.inc then we should be good here!

@agramfort agramfort merged commit 8983996 into mne-tools:main Sep 8, 2021
@welcome
Copy link

welcome bot commented Sep 8, 2021

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

@agramfort
Copy link
Member

thx @rezashr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mne.io.read_raw_curry() cannot read the event file end with '.cdt.ceo'

3 participants