Skip to content

Conversation

@drammock
Copy link
Member

  • converts "missing channel type" warning to logger.info
  • fixes bug where all channel loc fields in the info pointed to the same object in memory (so that when setting montage, all channels get the coords of whichever channel came last)
  • updates sleep tutorial to reflect new channel name behavior
  • fix the logic so that if user specifies stim_channel or misc args to read_raw_edf they don't get spurious warnings about unidentified channel types

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam2392 can you look ?

@adam2392
Copy link
Member

This LGTM for the EDF reader part!

@drammock
Copy link
Member Author

this is still missing a test that would have caught the previous error. probably something in mne/io/tests/test_meas_info.py... I'll try to get to that before I sign off today

@larsoner
Copy link
Member

Maybe mne/io/tests/test_raw.py in _test_raw_reader? That gets run by all mne/io/* readers

@drammock
Copy link
Member Author

locally the smoke test fails on main and passes on this branch, so assuming CIs all go green this is ready for merge.

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, whoever sees green first feel free to merge

@drammock
Copy link
Member Author

hmm, all green except for a timeout on Windows 3.9 conda 🤷🏻

@larsoner larsoner merged commit 533f589 into mne-tools:main Sep 15, 2021
@larsoner
Copy link
Member

Thanks @drammock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants