-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix EDF reader #9743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix EDF reader #9743
Conversation
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adam2392 can you look ?
|
This LGTM for the EDF reader part! |
|
this is still missing a test that would have caught the previous error. probably something in |
|
Maybe |
|
locally the smoke test fails on main and passes on this branch, so assuming CIs all go green this is ready for merge. |
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, whoever sees green first feel free to merge
|
hmm, all green except for a timeout on Windows 3.9 conda 🤷🏻 |
|
Thanks @drammock |
logger.infolocfields in the info pointed to the same object in memory (so that when setting montage, all channels get the coords of whichever channel came last)stim_channelormiscargs toread_raw_edfthey don't get spurious warnings about unidentified channel types