Make Info inherit from Bunch. #9757
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9752; a quick test of what would break if we change Info from a dict to a Bunch.
I gave it a quick test and the
copy()method fails.copy.deepcopy()doesn't bring the set attributes and raisesAttributeError: 'Info' object has no attribute 'ch_names'. Let's see if anything else breaks.For the
copy()method, one quick solution would be to leave the only propertych_namesin the code as it is now, but I think it might bite us later on.If not too much code breaks, let's put some more thoughts into
Bunchand how to copy it to make sure it will work as intended.