[BUG, MRG] Fix infinite recursion bug in get_montage_volume_labels
#9907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
reviewed
Oct 27, 2021
Member
agramfort
left a comment
agramfort
left a comment
There was a problem hiding this comment.
any chance we can update a test?
larsoner
reviewed
Oct 27, 2021
Contributor
Author
Okay this should have failed before now because it goes more than one voxel away. I also changed the default to 2 because 5 mm is a huge number of voxels which was tripping the max number of voxels and that's what was avoiding the infinite loop. |
agramfort
approved these changes
Oct 27, 2021
Member
agramfort
left a comment
agramfort
left a comment
There was a problem hiding this comment.
I'll try to restart the failing CI
Member
|
We can ignore the |
Member
|
Thanks @alexrockhill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_montage_volume_labelscan enter an infinite recursion because the voxel neighbors on every step are not removed, causing it to go from one voxel to the neighbor and back. This fixes that.