MRG, MAINT: Remove Mayavi #9945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
commented
Nov 3, 2021
|
|
||
| Coregistration / 3D viewer | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| :ref:`mne coreg` is an excellent tool for coregistration, but is limited | ||
| by being tied to Mayavi, Traits, and TraitsUI. We should first refactor in | ||
| several (mostly) separable steps: | ||
|
|
||
| 1. Refactor code to use traitlets | ||
| 2. GUI elements to use PyQt5 (rather than TraitsUI/pyface) | ||
| 3. 3D plotting to use our abstracted 3D viz functions rather than Mayavi | ||
| 4. Refactor distance/fitting classes to public ones to enable the example | ||
| from :gh:`6693`. | ||
|
|
||
| Once this is done, we can effectively switch to a PyVista backend. | ||
|
|
||
| .. _documentation-updates: |
Member
Author
There was a problem hiding this comment.
Congrats @GuillaumeFavelier for taking care of a roadmap item !!!
This was referenced Nov 4, 2021
Member
|
🍾 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting post-release deprecations with the biggest one, separate from the others: mayavi. I got rid of all instances of
pysurferandmayavifrom our code except the ones that are comments about copying/adapting code.cc @GuillaumeFavelier we need a public equivalent to
mayavi.core.api.Scenefor whatever we currently return forcreate_3d_figurethat users can pass around to 3D functions asfig=figetc. Can you work on this separately? Then we cangit grep PyVista rendererafter this PR and know all the places we need to put in a reference that links properly.