Add file with reading bug and event code #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@larsoner Should I keep the old name or replace it? I just wanted to give a name related to why I am replacing it but then I will have to rewrite the tests. |
Member
|
Either way is fine with me. I would personally just keep the old name to minimize the diff at the MNE level and add a comment in the test saying what the file has that's useful (weird sample numbers, truncation, whatever) |
Contributor
Author
|
okay @larsoner I think I am ready to merge. I ran the cnt.py tests and it didn't break anything. |
Member
|
I had to rebase but I checked the md5sum of the file before and after and they matches, so 🤞 that it works! |
proloyd
pushed a commit
to proloyd/mne-testing-data
that referenced
this pull request
Aug 20, 2024
* Update version.txt * Add event codes and file with reading bug that was fixed * Revert name * Delete file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR:
(mne-tools/mne-python#12393)
(mne-tools/mne-python#12392)