Open
Conversation
Early exit from a block is clearer.
This allows its use for error messages in the parent-- used in the next commit.
I think this will help with the papercut of "Did not find mosh server startup message". This message confuses people; often the real problem is that the command to start the remote mosh-server failed somehow. Fixes mobile-shell#1042, partially resolves mobile-shell#1005. Also relevant for mobile-shell#1042 and countless questions on IRC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully helps with a long-time papercut: If the command to start the remote Mosh server fails, the error reported may be "Did not find remote IP address (is SSH ProxyCommand disabled?)." or "Did not find mosh server startup message. (Have you installed mosh on your server?)" The first message, especially, can be rather misleading to new Mosh users. This change reports non-zero exitstatus instead, which I think will make things clearer.
There's a few PRs here on GitHub that mention this, but it's a frequent question on IRC.