Skip to content

Apply Clang formatting to #1167 and resolve merge conflicts#1292

Open
MahdiNazemi wants to merge 3 commits intomobile-shell:masterfrom
MahdiNazemi:master
Open

Apply Clang formatting to #1167 and resolve merge conflicts#1292
MahdiNazemi wants to merge 3 commits intomobile-shell:masterfrom
MahdiNazemi:master

Conversation

@MahdiNazemi
Copy link
Copy Markdown

@MahdiNazemi MahdiNazemi commented Aug 30, 2023 •
edited
Loading

Apply Clang formatting to #1167 and resolve merge conflicts

@matheusfillipe matheusfillipe mentioned this pull request Sep 11, 2023
Closed
@Diegovsky
Copy link
Copy Markdown

Diegovsky commented Feb 18, 2024

+1 on this pr

@eggbean
Copy link
Copy Markdown

eggbean commented Feb 18, 2024

Please merge!

1 similar comment
@i18nsite
Copy link
Copy Markdown

i18nsite commented Nov 13, 2024

Please merge!

This was referenced Nov 13, 2024
Open
Closed
bonryu added a commit to bonryu/mosh that referenced this pull request Jan 2, 2025
@bonryu
Merge pull request #1 from MahdiNazemi/master
70626de 
Applying pull request mobile-shell#1292 created by MahdiNazemi on the base mosh repo
@bonryu
Copy link
Copy Markdown

bonryu commented Jan 2, 2025 •
edited
Loading

This works for me using mosh (with MahdiNazemi/master patch applied to mosh/master) with kitty, and with or without tmux.
When using tmux, I think it magically works even without
set -ga terminal-overrides ',st*:Ss=\E[%p1%d q,st*:Se=\E[2 q'
in the .tmux.conf file.

(on Ubuntu 22.04 server and 22.10 client, I had to build mosh by first doing export CPPFLAGS=-std=c++17 before running ./configure --prefix=<myinstallpath>, make, sudo make install. See https://forum.manjaro.org/t/mosh-1-4-0-3-in-extra-not-working-because-of-linking-issues/144009/5 )

Thank you!!

@oscarmlage
Copy link
Copy Markdown

oscarmlage commented Apr 3, 2025

Any idea when this could be merged?

@ihasdapie
Copy link
Copy Markdown

ihasdapie commented Oct 10, 2025

+1 for this. Big quality of life update

@achimnol
Copy link
Copy Markdown

achimnol commented Nov 2, 2025

Waiting for this as well!

@achimnol achimnol mentioned this pull request Nov 5, 2025
Open
@lilydjwg
Copy link
Copy Markdown

lilydjwg commented Mar 23, 2026

FYI I have an updated patch that works on current master: ff85021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@MahdiNazemi @Diegovsky @eggbean @i18nsite @bonryu @oscarmlage @ihasdapie @achimnol @lilydjwg @matheusfillipe