Clarify port ranges in mosh-server(1) man page.#1378
Open
magical wants to merge 1 commit intomobile-shell:masterfrom
Open
Clarify port ranges in mosh-server(1) man page.#1378magical wants to merge 1 commit intomobile-shell:masterfrom
magical wants to merge 1 commit intomobile-shell:masterfrom
Conversation
The man page for mosh-server says that -p says it takes a "port or port-range" without specifying whether the range is exclusive or inclusive. It is inclusive. The man page also says that mosh-server binds to a port "between 60000 and 61000" by default without stating whether the endpoints are included. They are not; the range is exclusive. That is, the default is equivalent to -p 60001:60999, not -p 60000:61000 as one might reasonably suppose. Clarify the manual by sticking to inclusive ranges in both cases and stating explicitly that they are inclusive instead of leaving it up to the reader to guess.
Author
|
The default port range was set by Keith Winstein, in this commit from 2012: I could expand the range to match the documentation instead of changing the documentation to match the implementation, but it's been that way for so long it's probably best not to mess with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The man page for mosh-server says that -p says it takes a "port or port-range" without specifying whether the range is exclusive or inclusive. It is inclusive.
The man page also says that mosh-server binds to a port "between 60000 and 61000" by default without stating whether the endpoints are included. They are not; the range is exclusive.
That is, the default is equivalent to -p 60001:60999, not -p 60000:61000 as one might reasonably suppose.
Clarify the manual by sticking to inclusive ranges in both cases and stating explicitly that they are inclusive instead of leaving it up to the reader to guess.