Add support for SGR 2 faint and SGR 9 strikethrough#1380
Open
antonme wants to merge 2 commits intomobile-shell:masterfrom
Open
Add support for SGR 2 faint and SGR 9 strikethrough#1380antonme wants to merge 2 commits intomobile-shell:masterfrom
antonme wants to merge 2 commits intomobile-shell:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the ECMA-48 SGR attributes for faint (
2) andstrikethrough (
9), along with their reset sequences.In particular:
2enables faint / decreased intensity9enables strikethrough / crossed-out22clears both bold and faint29clears strikethroughThe implementation is intentionally small and only touches:
src/terminal/terminalframebuffer.hsrc/terminal/terminalframebuffer.ccsrc/tests/emulation-attributes.testIt wires the already-defined
faintattribute into the SGR parser/emitter andadds
strikethroughto the rendition enum so both attributes are parsed andre-emitted correctly.
Test coverage extends the existing
emulation-attributesregression test withcases for:
291;222;229;29This is a current rebase of the older #1059 change onto current
master.