This repository was archived by the owner on Dec 31, 2020. It is now read-only.
Conversation
danielkcz
reviewed
Apr 16, 2019
danielkcz
reviewed
Apr 16, 2019
danielkcz
reviewed
Apr 17, 2019
danielkcz
reviewed
Apr 17, 2019
Co-Authored-By: mweststrate <mweststrate@gmail.com>
Collaborator
|
Just want to make sure. Are you aware of linter failing? I would fix it, but I don't want to cause unnecessary merge conflicts and such. Hard to say if tests are actually passing :) I guess double rendering cannot be really fixed after all? |
Co-Authored-By: mweststrate <mweststrate@gmail.com>
Member
Author
|
ah, I fixed those, but forgot to push indeed :) |
Member
Author
|
Fixed |
Collaborator
|
LGTM. Would you mind adding simple tests to cover those error scenarios? It's an unnecessary drop in coverage imo. https://coveralls.io/builds/22890236/source?filename=src%2FuseAsObservableSource.ts#L8 |
rvion
reviewed
Apr 20, 2019
mweststrate
commented
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useLocalStoreautomatically converts functions to actions and binds them (and update readme example)?useAsObservableSourceonly accepts plain objects (not arrays)remove old docsremove old hooksfix double renderingUpdate issues #129, #106, #97, #94, #38, #22 accordingly after release