inject HOC display name

[SimeonC]

Before running around creating PR's everywhere I thought I'd ask why the inject HOC has a non-standard display name wrapper?

mobx-react/src/inject.js

Lines 37 to 43 in ab90ae6

	let displayName =
	"inject-" +
	(component.displayName ||
	component.name ||
	(component.constructor && component.constructor.name) ||
	"Unknown")
	if (injectNames) displayName += "-with-" + injectNames

Currently this means when we debug we get a wrapper like inject-Component or inject-Component-with-storeA. This is inconsistent with the rest of the HOC components like observer(Component).

Why isn't inject using displayName like inject(Component) or inject-with-storeA(Component)?

[mweststrate]

wasn't aware there was a standard for it :). Feel free to PR

[SimeonC]

Yea, I just found out about it when using a dev library that was parsing it this way.
React Docs Reference: https://reactjs.org/docs/higher-order-components.html#convention-wrap-the-display-name-for-easy-debugging
I'll see if I can get a PR up.

[ItamarShDev]

is it up for grabs, or @SimeonC is still on it?

[SimeonC]

AFAIK the PR is kinda in PR hell thanks to it being a breaking change. No idea when it’ll be merged in.

[ItamarShDev]

And isn't there any way to add it as a non breaking change?

I'm asking to learn, and not to lecture. I am new to the library

[SimeonC]

Not really. Though in this case "Breaking Change" shouldn't affect running code but it will affect any dev tools that rely on it. If you were to look at the Display Name (normally in React dev tools) currently you would see something like the following examples.

Before Change (Current)

<inject>
  <Component>
...

With this change it changes to;

<inject(Component)>
  <Component>
...

Or something like that (I'm a little fuzzy on the details - it has been 6 months).

[ItamarShDev]

should be added the label Breaking change?

[mweststrate]

Yeah, added it on the PR. I think this could be merged into the v6 branch once that stabilizes a bit.

…

On Fri, Feb 15, 2019 at 11:42 PM itamar sharify ***@***.***> wrote: should be added the label Breaking change? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#466 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvGhHlPVOQcR2g_LMCoLf5ENsGlkkJHks5vNzfTgaJpZM4TvMGS> .