This repository was archived by the owner on Dec 31, 2020. It is now read-only.
Optional dependencies to support Yarn PNP #693
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkcz
changed the title
Member
|
See also #479. Probably we could release this under a npm tag and ask few people to try |
|
Any news? I'm stuck with this |
Contributor
Author
|
If we eventually utilize the mobxjs/mobx-react-lite#214 in this package as well, it wouldn't be necessary to have this PR afaik. |
|
This PR is a minor/patch change, the other could be a breaking change. This could be merged straight away while the other is still open. Can this be merged while the other lands? |
Contributor
Author
|
Well, since there is not much of the interest in Yarn PNP (yet) then instead of merging something temporary, I will close this in favor #787 which I assume will be published soon and it's not a breaking change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretical fix for #596