update go-runc module, use runc.ExitError for container exec status#1741
Merged
Conversation
tonistiigi
approved these changes
Oct 20, 2020
| func (w *runcExecutor) run(ctx context.Context, id, bundle string, process executor.ProcessInfo) (int, error) { | ||
| return w.callWithIO(ctx, id, bundle, process, func(ctx context.Context, pidfile string, io runc.IO) (int, error) { | ||
| return w.runc.Run(ctx, id, bundle, &runc.CreateOpts{ | ||
| func updateRuntime(runtime *runc.Runc) { |
Member
There was a problem hiding this comment.
could we use a more descriptive name for the functionality
Collaborator
Author
There was a problem hiding this comment.
yeah, I didn't know what to call that. I have updated to updateRuncFieldsForHostOS which is not great either but is more descriptive. Let me know if you have a better name to use.
Signed-off-by: Cory Bennett <cbennett@netflix.com>
AkihiroSuda
approved these changes
Oct 20, 2020
Member
|
@AkihiroSuda Could you review containerd/go-runc#69 as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes status error handling for runc exec, also makes status error messages common between runc and containerd executors.
Pulls in latest go-runc mod.
Runc.PdeathSignalhas been moved upstream to beunixonly, so I have made the corresponding fix for the runc executor also.