add session injection to remote ref loading#1761
Merged
Merged
Conversation
tonistiigi
changed the title
tonistiigi
force-pushed
the
session-remote
branch
2 times, most recently
from
314e8c5 to
4f22962
Compare
tiborvass
approved these changes
Nov 3, 2020
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Allows readonly passed cleanly. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
session-remote
branch
from
b83d12c to
bdcee17
Compare
ktock
approved these changes
Nov 3, 2020
AkihiroSuda
approved these changes
Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to lazy pulls. Pass in session from the caller to handle cases where session drops or changes.
@sipsma
Draft: unit tests have not been updated. Checking if everything else is still working.Signed-off-by: Tonis Tiigi tonistiigi@gmail.com