use diff dir changes when using overlay#1918
Closed
saswatac wants to merge 1 commit into
Closed
Conversation
use diff dir change to compute the changeset for creating a layer when using overlay fs. it is more efficient than performing a full double diff walk. in overlay, the diff dir is just the first lower dir.
Member
|
This code is vendored from https://github.com/containerd/continuity and needs to be updated there. Should they reject your change as out-of-scope we can discuss more if we need to create our own fork. Didn't review the code but unclear to me if this handles the various xattrs created by overlayfs properly. Closing for now. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use diffDirChanges to compute the changeset for creating a layer
when using overlayfs. it is more efficient than performing a
full doubleWalkDiff.
in overlay, the diffdir is just the first lower dir.
resolves #1704
Note: this is just for review, can create PR in the containerd repo if this makes sense.