Test bump to runc rc95#2125
Closed
hinshun wants to merge 2 commits intomoby:masterfrom
Closed
Conversation
hinshun
force-pushed
the
runc-rc95
branch
2 times, most recently
from
b927ab9 to
79bf7ad
Compare
Member
|
Looks like doesn't cause failure atm. Btw, we don't usually update runc vendoring on its own but do it with containerd vendor update to the same version they are using. A binary update should be enough for this case. |
Collaborator
Author
|
Ok I'll try to write a test that fails in this PR before I port it over to #2123 |
Signed-off-by: Edgar Lee <edgarl@netflix.com>
Signed-off-by: Edgar Lee <edgarl@netflix.com>
Collaborator
Author
|
@tonistiigi Added a failing test that only bumps the binary, which passes when ran with #2123 |
Collaborator
Author
|
Closing this since #2123 is merged. |
Member
|
we can still update to rc95 |
Collaborator
Author
|
@tonistiigi Do we want to wait until containerd bumps to rc95 or is buildkit going to move independently? |
Member
|
You can bump containerd binary to 1.5.2 as well. Vendor changes can be done separately when needed. |
Member
|
Seems covered in https://github.com/moby/buildkit/pull/2145/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking if there is a CI failure when bumping to rc95.
Related to: #2123