exporter: support for compression-level#2591
Merged
tonistiigi merged 1 commit intomoby:masterfrom Feb 3, 2022
Merged
Conversation
ktock
reviewed
Feb 1, 2022
AkihiroSuda
reviewed
Feb 1, 2022
| * `dangling-name-prefix=[value]`: name image with `prefix@<digest>` , used for anonymous images | ||
| * `name-canonical=true`: add additional canonical name `name@<digest>` | ||
| * `compression=[uncompressed,gzip,estargz,zstd]`: choose compression type for layers newly created and cached, gzip is default value. estargz should be used with `oci-mediatypes=true`. | ||
| * `compression-level=[value]`: compression level for gzip, estargz (0-9) and zstd (0-22) |
Member
There was a problem hiding this comment.
Could you add the default value?
Member
Author
There was a problem hiding this comment.
There is no universal default value. -1 is the default in gzip.
Member
Author
There was a problem hiding this comment.
Actually, I see I made -1 match default inzstd as well(although non-spec). But estagz might still want a different default #2591 (comment)
compression-level option can be set on export to define the preferred speed vs compression ratio. The value is a number dependent on the compression algorithm. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
compression-level-2
branch
from
0d69f2c to
cab33b1
Compare
ktock
approved these changes
Feb 2, 2022
AkihiroSuda
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces #2350
compression-leveloption can be set on export todefine the preferred speed vs compression ratio. The
value is a number dependent on the compression algorithm.
@ktock
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com