Fix refs ignoring gc labels of contents#2674
Merged
Merged
Conversation
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
tonistiigi
reviewed
Feb 24, 2022
| require.NoError(t, err) | ||
| defer cleanup() | ||
|
|
||
| ctx, done, err := leaseutil.WithLease(ctx, co.lm, leaseutil.MakeTemporary) |
Collaborator
Author
There was a problem hiding this comment.
To check if the lease on each ref (not the one in ctx) is effective. The context lease prevents contents are garbage collected during its lifecycle so hides the issue.
tonistiigi
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following-up #2603
Though compression variants are linked using gc labels, they can be ignored and garbage collected because the lease of each ref has a lable
containerd.io/gc.flatwhich ignores the label references of the leased blob.This commit fixes this issue by introducing a new lease for compression variants. This lease doesn't have
containerd.io/gc.flatlabel to allow label references.Reproducing issue:
sha256:03901b4a2ea88eeaad62dbe59b072b28b6efa00491962b8741081c5df50c65e0can be garbage collected.