Skip to content

vendor: github.com/containerd/containerd v1.6.3#2833

Merged
crazy-max merged 2 commits intomoby:masterfrom
crazy-max:update-containerd
Apr 28, 2022
Merged

vendor: github.com/containerd/containerd v1.6.3#2833
crazy-max merged 2 commits intomoby:masterfrom
crazy-max:update-containerd

Conversation

@crazy-max
Copy link
Member

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@@ -1,7 +1,7 @@
# syntax=docker/dockerfile-upstream:1.4

ARG RUNC_VERSION=v1.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update runc too, but that can be another PR

Copy link
Member Author

@crazy-max crazy-max Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I was talking with @thaJeztah and @tonistiigi about this one. We could temporarily patch libseccomp using go mod edit with seccomp/libseccomp-golang#85 for runc stage in the Dockerfile. WDYT?

Copy link
Member

@AkihiroSuda AkihiroSuda Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just download the runc binary from https://github.com/opencontainers/runc/releases/tag/v1.1.1 ?

Maybe we have discussed this before and we found that the runc upstream lacks RISC-V binary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see it merged in libseccomp; carried tonis's PR last week to try to unblock it; please review that one (hopefully it will help getting attention of the maintainers there) seccomp/libseccomp-golang#90

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR for upstream runc.riscv64:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants