Ensure exporter progress logs are properly keyed#2953
Merged
tonistiigi merged 1 commit intomoby:masterfrom Jul 23, 2022
Merged
Conversation
tonistiigi
reviewed
Jul 18, 2022
605a5a1 to
3b06d0c
Compare
tonistiigi
reviewed
Jul 19, 2022
Member
tonistiigi
left a comment
There was a problem hiding this comment.
Now they are only unique based on image export of cache export. I don't understand how this is related to the bake problem in the initial comment.
This patch ensures that all progress outputs for exporters are properly keyed uniquely to the session, to ensure that duplicate exporters across different sessions do not conflict and produce confusing results. Currently, this behavior isn't relied upon by buildkit, but is used by buildx bake, where multiple image exporters might be invoked at the same time. Signed-off-by: Justin Chadwell <me@jedevc.com>
3b06d0c to
f7922fb
Compare
Member
Author
|
Woops, have split out the cache inline cache properly as well. The cache exports need to be properly split out similarly, or we see the same kind of issue for inline cache: vs and for the other cache types: vs Essentially, we need to force the logs here to be unique per session (previously they were derived exclusively from the exporter's |
tonistiigi
approved these changes
Jul 23, 2022
emmanuelguerin
pushed a commit
to emmanuelguerin/buildkit
that referenced
this pull request
Mar 31, 2025
docs: update bake reference to use composable attrs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue with bake's progress output, where multiple exporters of the same type might be invoked, resulting in the logs writing over each other within the same section. Additionally, this will be important in the context of #2760, where the progress logs per output need to be appropriately separated.
Sample bake file:
Before:
After: