Attestations refactoring#3073
Merged
tonistiigi merged 7 commits intomoby:masterfrom Sep 21, 2022
Merged
Conversation
jedevc
force-pushed
the
attestations-refactor
branch
2 times, most recently
from
30c2bd5 to
66701f5
Compare
jedevc
referenced
this pull request
in tonistiigi/buildkit
Sep 5, 2022
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
reviewed
Sep 7, 2022
jedevc
force-pushed
the
attestations-refactor
branch
from
66701f5 to
4035a67
Compare
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
attestations-refactor
branch
from
4035a67 to
23d778c
Compare
tonistiigi
approved these changes
Sep 21, 2022
| Path: "/attestation.json", | ||
| InToto: result.InTotoAttestation{ | ||
| PredicateType: "https://example.com/attestations/v1.0", | ||
| Subjects: []result.InTotoSubject{{ |
Member
There was a problem hiding this comment.
This isn't needed anymore iiuc
emmanuelguerin
pushed a commit
to emmanuelguerin/buildkit
that referenced
this pull request
Mar 31, 2025
history: add export command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows-up #2935:
AddAttestationfunction to be less hackyAttestationinterface into a single struct - this also flattens the gateway protobuf.