client: add extra debug to tests#3442
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Jun 29, 2023
Merged
Conversation
AkihiroSuda
reviewed
Dec 31, 2022
| select { | ||
| case <-ctx.Done(): | ||
| onFinalStatus = true | ||
| ctx = context.TODO() |
Member
There was a problem hiding this comment.
Could you add a comment line to explain this?
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
jedevc
approved these changes
Jun 29, 2023
AkihiroSuda
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to debug #3401 but couldn't repro or understand how the race is possible as long as tests do not have inner parallelization. Adding more debug so if it happens again we have some extra data.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com